Skip to content

Update coin_change.py #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Update coin_change.py #2613

wants to merge 6 commits into from

Conversation

Mohitkumar6122
Copy link

Describe your change:

Fixed #2612
updated coin change problem

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@poyea
Copy link
Member

poyea commented Oct 1, 2020

Usually we ask for input from users. Can you change it?

@Mohitkumar6122
Copy link
Author

Usually we ask for input from users. Can you change it?

yeah sure

Mohitkumar6122
Mohitkumar6122 commented Oct 1, 2020
View reviewed changes
Copy link
Author

@Mohitkumar6122 Mohitkumar6122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated ( takes input from user )

Kush1101
Kush1101 reviewed Oct 3, 2020
View reviewed changes
Copy link
Member

@Kush1101 Kush1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a useful contribution. Please bring forward a genuine idea/implementation to contribute

@Kush1101 Kush1101 closed this Oct 3, 2020
@Mohitkumar6122 Mohitkumar6122 deleted the patch-2 branch October 3, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kush1101 Kush1101 Kush1101 left review comments

Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update coin change
3 participants
@Mohitkumar6122 @poyea @Kush1101